-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Feature/code supernova #8188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/code supernova #8188
Conversation
…onal marketing emails.
- Adds new UI message promoting stealth model Code Supernova - Adds pro trial buttons to the provider page when Roo Code Cloud is selected - Adds pro trial buttons to the Cloud page - Updates internationalization files across all supported languages
| "testApiAuthentication": "测试 API 认证", | ||
| "signIn": "连接到 Roo Code Cloud", | ||
| "connect": "立即连接", | ||
| "connect": "Connect to Roo Code Cloud", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User-facing strings such as 'Connect to Roo Code Cloud' (and similarly on 'Start Free Pro Trial' in settings) remain in English. Confirm that this is intentional for Chinese users to maintain brand consistency.
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.
| "autoApprovePowerUser": "Giving Roo some independence? Control it from anywhere with Roo Code Cloud. <learnMoreLink>Learn more</learnMoreLink>.", | ||
| "longRunningTask": "This might take a while. Continue from anywhere with Cloud.", | ||
| "taskList": "Roo Code Cloud is here: follow and control your tasks from anywhere. <learnMoreLink>Learn more</learnMoreLink>." | ||
| "taskList": "💫 CODE SUPERNOVA 🌌<lineBreak/>Astronomical context • Long-running tasks • Mobile management via Roo Code Pro<lineBreak/>Try both free today by selecting <providersLink>provider Roo Code Cloud</providersLink>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the test procedure section of the PR description: "app.roocode.com/bililng" should be "app.roocode.com/billing" (missing 'l'). While this isn't in the code itself, it could cause confusion during testing.
| "authenticatedMessage": "Securely authenticated through your Roo Code Cloud account.", | ||
| "connectButton": "Connect to Roo Code Cloud" | ||
| "connectButton": "Connect to Roo Code Cloud", | ||
| "startFreeTrialButton": "Start Free Pro Trial" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Start Free Pro Trial" button text should be properly internationalized. Currently it's hardcoded in English across all locale files. Consider using a translation key like "startFreeTrialButton" with appropriate translations for each locale.
| {t("cloud:connect")} | ||
| </VSCodeButton> | ||
| <> | ||
| <VSCodeButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This button logic is duplicated in ApiOptions.tsx (lines 666-679). Could we extract this into a shared component to avoid duplication and ensure consistency?
| </div> | ||
| ) : ( | ||
| <div className="flex flex-col gap-2"> | ||
| <VSCodeButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates the button logic from CloudView.tsx. Consider extracting into a shared component to maintain DRY principles and ensure consistent behavior across the app.
| <li> | ||
| <strong>Send product updates and roadmap communications</strong> (opt‑out available) | ||
| </li> | ||
| <li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The privacy policy now includes a section on marketing communications. Has this been reviewed by legal to ensure compliance with applicable data protection regulations (GDPR, CCPA, etc.)?
|
|
||
| expect(container.firstChild).toHaveClass("flex", "flex-col", "gap-3") | ||
| }) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition of the fallback test case! Consider adding more edge cases:
- What happens when both tasks and recentTasks are empty?
- What happens when tasks has fewer than 3 items?
- Test the interaction between filtered and recent tasks
| break | ||
| } | ||
| case "openSettings": { | ||
| // Execute the settings command to open the settings panel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? The new "openSettings" message type executes a settings command. Could we add a comment explaining what settings panel this opens and why it's needed for the CODE SUPERNOVA feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree with this, not really sure why this new message is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a look now.
- Updated wording for Code Supernova stealth model promotion - All tests now passing - Refined UI messaging and user experience
|
Closing for now, let me know if this needs to be reviewed, I believe we already have implemented this. |
💫 CODE SUPERNOVA 🌌
Astronomical context • Long-running tasks • Mobile management via Roo Code Pro
Try both free today by selecting provider Roo Code Cloud
Related GitHub Issue
No issue...
Roo Code Task Context (Optional)
This PR promotes 💫 CODE SUPERNOVA 🌌 on the task page and adds Roo Code Cloud Upsell Buttons to the Provider page because long context windows demand Roomote Control
Description
Test Procedure
[ ] Look for the updated message on the app extension page
[ ] Log out from Roo Code Cloud. Go to the provider settings page. Select Roo Code Cloud. You should see two buttons here where before there was just one. The Free Trial one should take you to app.roocode.com/billing. The Connect to Roo Code Cloud one should connect you to Roo Code Cloud
[ ] Log out from Roo Code Cloud. Go to the cloud page. You should see two buttons where there was just one. The Free Trial one should tak you to app.roocode.com/bililng. The Connect to Roo Code Cloud one should connect you to Roo Code Cloud.
Pre-Submission Checklist
Screenshots / Videos
Before
After
Documentation Updates
None needed
Additional Notes
None needed
Get in Touch
jdilla1277
Important
This PR adds promotional content and upsell buttons for Roo Code Cloud, updates the privacy policy, and enhances task management features.
cloud.jsonfor multiple languages to include new promotional content.app.roocode.com/billingand connect to Roo Code Cloud.privacy/page.tsx.openSettingsmessage type inWebviewMessage.tsand handles it inwebviewMessageHandler.ts.ChatView.tsxandHistoryPreview.tsxto handle recent tasks and task history.cloud.jsonandsettings.jsonfiles for various languages.This description was created by
for db84a07. You can customize this summary. It will automatically update as commits are pushed.